Update AdvanceQuantizeOpAboveDefChainPass, PostponeDequantizeOpBelowUseChainPass, and ScalarToTensorPass to correctly set modified bit #16230
+51
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16230
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit b6187a8 with merge base 5b4900c ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
DrJessop
force-pushed
the
export-D87900822
branch
from
016d6f6 to
b5a57d1
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Dec 12, 2025
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Differential Revision: D87900822
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Dec 12, 2025
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Differential Revision: D87900822
DrJessop
force-pushed
the
export-D87900822
branch
from
b5a57d1 to
113c1f3
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Dec 12, 2025
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Differential Revision: D87900822
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Reviewed By: hsharma35 Differential Revision: D87900822
DrJessop
force-pushed
the
export-D87900822
branch
from
113c1f3 to
bd6cb66
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Reviewed By: hsharma35 Differential Revision: D87900822
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Reviewed By: hsharma35 Differential Revision: D87900822
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Reviewed By: hsharma35 Differential Revision: D87900822
DrJessop
force-pushed
the
export-D87900822
branch
from
bd6cb66 to
b6187a8
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Reviewed By: hsharma35 Differential Revision: D87900822
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Jan 9, 2026
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230) Summary: Update - AdvanceQuantizeOpAboveDefChainPass - PostponeDequantizeOpBelowUseChainPass to correctly track modified bit and updated tests to check for numerical correctness. Reviewed By: hsharma35 Differential Revision: D87900822
ethansfng
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update
to correctly track modified bit and updated tests to check for numerical correctness.
Differential Revision: D87900822